Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add water quality data to site model and add site filter #1076

Merged
merged 16 commits into from
Jan 25, 2025
Merged

Add water quality data to site model and add site filter #1076

merged 16 commits into from
Jan 25, 2025

Conversation

yaodingyd
Copy link
Collaborator

fix #1026
/claim #1026

Add waterQuality to site model that would include list of water quality metrics.

The logics to determine water quality metrics is from

aqualink-app/packages/website/src/common/SiteDetails/index.tsx

Lines 157 to 174 in 56dbb9c

const combinedArray = [...forecastData, ...latestData];
const parsedData = parseLatestData(combinedArray);
const hasSpotter = Boolean(parsedData.bottomTemperature);
const hasSonde =
sondeMetrics.filter((x) => Boolean(parsedData[x])).length >=
MINIMUM_SONDE_METRICS_TO_SHOW_CARD;
const hasHUI =
latestData.some((x) => x.source === 'hui') ||
sourceWithinDataRangeInterval(
acceptHUIInterval,
'hui',
timeSeriesRange,
);
setHasSondeData(hasSonde);
setHasSpotterData(hasSpotter);
setHasHUIData(hasHUI);

which looks at LatestData entity (and forecast data, omitted by now) and check if they have hui source or enough sonde metrics.

If this is the correct direction, I can work on a follow up to remove the checks in frontend and consolidate to the backend, so we have single source of truth. This also avoid multiple data fetching to get water quality data

pullrequest[bot]
pullrequest bot reviewed Dec 17, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yaodingyd you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Dec 17, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 70
- 1

85% TypeScript
15% Jest Snapshot (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

@yaodingyd yaodingyd mentioned this pull request Dec 17, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Build succeeded and deployed at https://aqualink-app-1076.surge.sh
(hash 9df237c deployed at 2025-01-23T22:47:59)

@yaodingyd yaodingyd marked this pull request as draft December 17, 2024 15:28
pullrequest[bot]
pullrequest bot reviewed Dec 17, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request would normally not be reviewed by PullRequest because the pull request is a draft; however since a review was already requested, it is currently being reviewed by the PullRequest network. If you would like to cancel it, you can do so manually from the PullRequest dashboard.

pullrequest[bot]
pullrequest bot reviewed Dec 17, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. I don't have any concerns with these changes, security or otherwise.

Image of Graham C Graham C

Reviewed with ❤️ by PullRequest

@yaodingyd yaodingyd marked this pull request as ready for review December 17, 2024 16:45
pullrequest[bot]
pullrequest bot reviewed Dec 18, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1076 up until the latest commit (a17524a). No further issues were found.

Reviewed by:

Image of Graham C Graham C

pullrequest[bot]
pullrequest bot reviewed Jan 2, 2025
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

@K-Markopoulos K-Markopoulos self-requested a review January 21, 2025 15:59
K-Markopoulos
K-Markopoulos reviewed Jan 23, 2025
View reviewed changes
packages/api/src/sites/sites.entity.ts Outdated Show resolved Hide resolved
packages/api/src/utils/site.utils.ts Outdated Show resolved Hide resolved
packages/api/src/utils/site.utils.ts Show resolved Hide resolved
packages/api/src/utils/site.utils.ts Outdated Show resolved Hide resolved
packages/api/src/utils/site.utils.ts Outdated Show resolved Hide resolved
K-Markopoulos
K-Markopoulos approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@K-Markopoulos K-Markopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 🚀

@ericboucher ericboucher changed the title Add water quality data to site model and use it to power site filter Add water quality data to site model and add site filter Jan 25, 2025
@ericboucher ericboucher merged commit 989231f into master Jan 25, 2025
4 checks passed
@ericboucher ericboucher deleted the yd/water-quality branch January 25, 2025 15:30
@algora-pbc algora-pbc bot mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@ericboucher ericboucher ericboucher left review comments

@K-Markopoulos K-Markopoulos K-Markopoulos approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add water quality sites in the map filter
3 participants
@yaodingyd @ericboucher @K-Markopoulos